Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onRowSelect called instead of onRowUnselect #835

Closed
Hafas opened this issue Apr 4, 2019 · 0 comments · Fixed by #836
Closed

onRowSelect called instead of onRowUnselect #835

Hafas opened this issue Apr 4, 2019 · 0 comments · Fixed by #836
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@Hafas
Copy link
Contributor

Hafas commented Apr 4, 2019

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)

https://codesandbox.io/s/3v87j2z3v5

Current behavior
When defining a DataTable with a Column with selectionMode="multiple, the callback onRowUnselect is never called. Actually when unselecting a row the callback onRowSelect is called instead.

Expected behavior
When unselecting a row the callback onRowUnselect should be called.

Minimal reproduction of the problem with instructions

https://codesandbox.io/s/3v87j2z3v5

  • React version:
    16.8.6

  • PrimeReact version:
    3.1.0

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    all

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    all

mertsincan added a commit that referenced this issue Apr 22, 2019
Fixed #835 - Call onRowUnselect when unselecting row
@mertsincan mertsincan self-assigned this Apr 22, 2019
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Apr 22, 2019
@mertsincan mertsincan added this to the 3.1.3 milestone Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants