Fix #2808: MegaMenu start and end template attributes #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
added
the
Status: Pending Review
melloware
commented
Apr 27, 2022
| @@ -52,18 +52,6 @@ export const Menubar = React.memo(React.forwardRef((props, ref) => { | |||
| useCustomContent | |||
| })); | |||
|
|
|||
| const createCustomContent = () => { | |||
There was a problem hiding this comment.
This method was dead unused code in MenuBar.
|
Hi @melloware, Thanks a lot for this feature! Were you able to test it with orientation="vertical"? Also, can you create a separate demo for this instead of replacing the existing demo? |
mertsincan
added
the
Resolution: Needs Revision
|
OK good points and I think I definitely need to do more work on vertical may need your help with some CSS 😄 |
|
Fixed and updated examples.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###Feature Requests
Fix #2808: MegaMenu start and end template attributes
This now brings it in line API wise with the
MenuBar.