Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4669: DataTable restore width fix #4682

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

PasBazz
Copy link
Contributor

@PasBazz PasBazz commented Jul 24, 2023

Defect Fixes

Fix #4669 The problem arose due to the fact that after restoring the width, a inline style was added to the root element and after that the scroll was lost.

image

@vercel
Copy link

vercel bot commented Jul 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Jul 24, 2023 0:52am

@melloware
Copy link
Member

Thanks for your contribution. I will test it out!

@melloware
Copy link
Member

That line was added in this ticket: #2368

Not sure if it was because when you resize column on the far right to expand it needs to increase the size of the whole table? Can you try that?

@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jul 25, 2023
@PasBazz
Copy link
Contributor Author

PasBazz commented Jul 26, 2023

I recorded the process of restoring the table width before the fix and afterwards.

Before correction:

Datatablet_error

After correction:

Datatablet_fix

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jul 26, 2023
@melloware melloware merged commit d873981 into primefaces:master Jul 26, 2023
3 of 5 checks passed
@PasBazz PasBazz deleted the bug_4669 branch July 26, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataTable: The scrollbar disappears after the size is restored
2 participants