Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6396: Password use IconField for toggle mask #6493

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Fix #6396: Password use IconField for toggle mask #6493

merged 1 commit into from
Apr 30, 2024

Conversation

melloware
Copy link
Member

@melloware melloware commented Apr 29, 2024 •
edited
Loading

Fix #6396: Password use IconField for toggle mask
Fix #6349

@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 5:20pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 5:20pm

@melloware melloware added Core Team Issue or pull request has been *opened* by a member of Core Team Status: Pending Test Issue or pull request is being tested by Core Team labels Apr 29, 2024
@nitrogenous nitrogenous added this to the 10.6.4 milestone Apr 29, 2024
nitrogenous
nitrogenous approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@nitrogenous nitrogenous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect improvement

@nitrogenous nitrogenous merged commit 935f481 into primefaces:master Apr 30, 2024
7 checks passed
@melloware melloware deleted the PR6396 branch April 30, 2024 11:32
@nitrogenous nitrogenous removed this from the 10.6.4 milestone Apr 30, 2024
@sja-cslab sja-cslab mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrogenous nitrogenous nitrogenous approved these changes

Assignees

@nitrogenous nitrogenous

Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Status: Pending Test Issue or pull request is being tested by Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Password: icon with togglemask Password - Toggle Mask incorrect icon positioning
2 participants
@melloware @nitrogenous