Fix #6632 InputOtp keyboard navigation #6638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
I can only reproduce the second bug in Firefox Latest Firefox: Screen.Recording.2024-05-17.at.16.03.30.movLatest version of Chrome: Screen.Recording.2024-05-17.at.16.02.05.movI have checked other UI libraries like MUI, Chackra, ant-desing and they all behave the same, I also noticed that this error appears in some specific tag combinations, for example the ant-desing example works fine until I remove the h5 title inside container input-otp |
KirilCycle
commented
May 17, 2024
components/lib/inputotp/InputOtp.js
Outdated
| if ((props?.integerOnly && !((event.code.startsWith('Digit') || event.code.startsWith('Numpad')) && Number(event.key) >= 0 && Number(event.key) <= 9)) || (tokens.join('').length >= props.length && event.code !== 'Delete')) { | ||
| //Ignore Enter and Tab pressing and Prevent non-numeric characters from being entered if integerOnly is true or if the length of the input is greater than the specified length | ||
| if ( | ||
| event.code !== 'Tab' && |
There was a problem hiding this comment.
It is better to put it in separate cases to make it look cleaner
|
Why not just this... case 'Tab':
case 'Enter': {
// allow these keys
break;
}basically if Enter or Tab just allow the key. |
Yes, i noticed that |
melloware
approved these changes
May 17, 2024
melloware
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fix #6632 ignore Tab and Enter pressing