Fixed #5844 - Message props default value changes

primefaces · Jun 6, 2024 · 8d2caf1 · 8d2caf1
1 parent 9f197f0
commit 8d2caf1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 23 deletions.
diff --git a/components/lib/message/BaseMessage.vue b/components/lib/message/BaseMessage.vue
@@ -12,15 +12,11 @@ export default {
         },
         closable: {
             type: Boolean,
-            default: true
-        },
-        sticky: {
-            type: Boolean,
-            default: true
+            default: false
         },
         life: {
             type: Number,
-            default: 3000
+            default: null
         },
         icon: {
             type: String,

diff --git a/components/lib/message/Message.d.ts b/components/lib/message/Message.d.ts
@@ -111,17 +111,18 @@ export interface MessageProps {
     severity?: HintedString<'success' | 'info' | 'warn' | 'error' | 'secondary' | 'contrast'> | undefined;
     /**
      * Whether the message can be closed manually using the close icon.
-     * @defaultValue true
+     * @defaultValue false
      */
     closable?: boolean | undefined;
     /**
+     * @deprecated since 4.0.
      * When enabled, message is not removed automatically.
      * @defaultValue true
      */
     sticky?: boolean | undefined;
     /**
      * Delay in milliseconds to close the message automatically.
-     * @defaultValue 3000
+     * @defaultValue null
      */
     life?: number | undefined;
     /**

diff --git a/components/lib/message/Message.vue b/components/lib/message/Message.vue
@@ -40,28 +40,18 @@ export default {
             visible: true
         };
     },
-    watch: {
-        sticky(newValue) {
-            if (!newValue) {
-                this.closeAfterDelay();
-            }
-        }
-    },
     mounted() {
-        if (!this.sticky) {
-            this.closeAfterDelay();
+        if (this.life) {
+            setTimeout(() => {
+                this.visible = false;
+                this.$emit('life-end');
+            }, this.life);
         }
     },
     methods: {
         close(event) {
             this.visible = false;
             this.$emit('close', event);
-        },
-        closeAfterDelay() {
-            setTimeout(() => {
-                this.visible = false;
-                this.$emit('life-end');
-            }, this.life);
         }
     },
     computed: {