Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrimeVue docs inconsistency between code and output for Panel component #4734

Closed
shawnyama opened this issue Nov 1, 2023 · 0 comments · Fixed by #4735
Closed

PrimeVue docs inconsistency between code and output for Panel component #4734

shawnyama opened this issue Nov 1, 2023 · 0 comments · Fixed by #4735
Labels
Component: Documentation Issue or pull request is related to Documentation

Comments

@shawnyama
Copy link

shawnyama commented Nov 1, 2023 •
edited
Loading

Describe the bug

I was looking at how to add an icon button to the header of the Panel component like the cog seen here: https://primevue.org/panel/#template

Then I noticed that its sample code is missing the cog button. If I were to open the code in StackBlitz the output doesn't have the cog button so there is a mismatch is in the docs.

I would like to know exactly how this cog was added.

Reproducer

https://stackblitz.com/run?file=src%2FApp.vue

PrimeVue version

3.25.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@shawnyama shawnyama added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 1, 2023
FlipWarthog added a commit to FlipWarthog/primevue that referenced this issue Nov 1, 2023
@FlipWarthog
Fix primefaces#4734 - PrimeVue docs inconsistency between code and ou…
e4cfcea 
…tput for Panel component
@FlipWarthog FlipWarthog mentioned this issue Nov 1, 2023
Merged
tugcekucukoglu added a commit that referenced this issue Nov 3, 2023
@tugcekucukoglu
Merge pull request #4735 from FlipWarthog/PV4734
94bc251 
Fix #4734 - PrimeVue docs inconsistency between code and output for Panel component
@tugcekucukoglu tugcekucukoglu added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Milestone
No milestone
2 participants
@shawnyama @tugcekucukoglu