Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfirmDialog and ConfirmPopup: Missing accept/reject labels #6075

Closed
m-kutnik opened this issue Jul 17, 2024 · 0 comments · Fixed by #6077
Closed

ConfirmDialog and ConfirmPopup: Missing accept/reject labels #6075

m-kutnik opened this issue Jul 17, 2024 · 0 comments · Fixed by #6077
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.0.2

Comments

@m-kutnik
Copy link
Contributor

m-kutnik commented Jul 17, 2024 •
edited
Loading

Describe the bug

Due to invalid if statements in ConfirmDialog and ConfirmPopup, the default labels for accept and reject actions are not returned, causing the component to display empty buttons.

Reproducer

https://stackblitz.com/edit/primevue-missing-confirmation-labels?file=src%2FApp.vue

PrimeVue version

4.0.0

Vue version

3.x

Language

ALL

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

  • call confirm.require() without acceptProps/acceptLabel/rejectProps/rejectLabel

Expected behavior

According to the docs, the default values for the labels should be inherited from the Primevue's locale ($primevue.config.locale.reject and $primevue.config.locale.accept)
@m-kutnik m-kutnik added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 17, 2024
@m-kutnik m-kutnik mentioned this issue Jul 17, 2024
Merged
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 26, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.1.0 milestone Jul 26, 2024
tugcekucukoglu added a commit that referenced this issue Jul 26, 2024
@tugcekucukoglu
Refactor #6075
573c041
@tugcekucukoglu tugcekucukoglu modified the milestones: 4.1.0, 4.0.2 Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.0.2
Development

Successfully merging a pull request may close this issue.

fix: missing default labels in ConfirmDialog and ConfirmPopup m-kutnik/primevue
2 participants
@m-kutnik @tugcekucukoglu