Fix #4595 - Button slots not working #4597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LanFeusT23
changed the title
LanFeusT23
changed the title
LanFeusT23
changed the title
|
Ok as expected I have issues with the tests, I was barely able to run them locally to begin with - but it seems the PR is running into problems as well I'm honestly not sure how to fix |
|
If you want to use the default slot, you must do all the other icon, loadingicon and label adding operations yourself. |
|
I don't understand. What's the point of having a slots for default, loading and loadingicon if you can't use any of them the moment you use the default slot? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4595
Button slots for
iconandloadingiconshould now be functional