-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(portal): enable global 'body' override for Portal's appendTo
#5134
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
appendTo
appendTo
appendTo
appendTo
Hi @patroza, Great, we already added this to PrimeReact. Can you change the name of the option like in PrimeReact? https://primereact.org/configuration/#appendto
|
And could you please create an issue with 'new feature' label for it? Thanks a lot for your contribution! |
Hi @mertsincan, thanks, I've made the adjustment and created the discussion here, not sure how to add a label, don't see the usual option for it. |
Deployment failed with the following error:
|
hi, |
From Discord, as described, a way to override the 'body' element for Portal, so that e.g when one builds components that may be used inside web components, portals can be created within another web component that contains the required styles.
This is necessary because the host page won't contain the styles that are generally expected by components that use portals. (e.g Toast, Menu and Dialog).
main:
Portal.ce.vue: