Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic labels for Menu components #637

Closed
wants to merge 1 commit into from
Closed

Dynamic labels for Menu components #637

wants to merge 1 commit into from

Conversation

mllull
Copy link

@mllull mllull commented Nov 13, 2020

I have modified label prop on MenuItem, now it accepts a simple string or a function. Whit function, you can provide dynamic text.

It closes #449.

@cagataycivici
Copy link
Member

This only resolves it for menu component, others should be supported too. We'll take it from here, thank you very much.

@cagataycivici cagataycivici self-assigned this Nov 17, 2021
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Nov 17, 2021
@cagataycivici cagataycivici added this to the 3.9.0 milestone Nov 17, 2021
@cagataycivici cagataycivici changed the title Added dynamic text to labeltext on MenuItem Dynamic labels for Menu components Nov 17, 2021
@cagataycivici cagataycivici removed this from the 3.9.0 milestone Nov 17, 2021
@cagataycivici cagataycivici removed the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Nov 17, 2021
@cagataycivici cagataycivici removed their assignment Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic labels for Menu components
2 participants