Proposal for #5463: Add a resetState method to splitter to manually reset state #6394
+39
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally reset state.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
tugcekucukoglu
approved these changes
Sep 24, 2024
|
Hello, thank you for making Primevue more and more usable. I would love to know if this has been released yet, because I'm on the latest release and still experience the issue this PR addresses? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm encountering the issue #5463, and I don't think the approach proposed by matansha is ideal. Recalculating the "initial" state on every component update will reset user resize actions each time the component is updated, making it unusable.
One potential solution could be for the Splitter to observe changes on the size property of each SplitterPanel. However, this seems risky because these values might be updated simultaneously across all panels, leading to unintended frequent updates.
A more straightforward approach could be to introduce a reset function on the Splitter component, allowing users to manually re-run the initialization code (initializeState).
For those who want permanent synchronization, they could add a watcher on the size props to trigger a reset on each update.
resolves #5463