Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐻 Component Refresh (charming soft) #1025

Merged
merged 151 commits into from
Jul 2, 2020
Merged

🐻 Component Refresh (charming soft) #1025

merged 151 commits into from
Jul 2, 2020

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Feb 13, 2020

⚠️ Don't merge this into master just yet. It will most likely be released as Primer CSS 15.0.0.

This PR is only to test changes with a different package name (@primer/css-next) so it can be installed in parallel to @primer/css.

charming soft

🔍 All PRs merged into next (so far).

How to use this branch

  1. Make a PR and change the base branch to next
    • You might wanna branch off from next if your changes are related.
  2. When the PR is approved, merge it
  3. In dotcom run bin/npm install @primer/css-next@canary
    • Or e.g. bin/npm install @primer/[email protected] if you want to rollback to a previous PR

How to release this branch

Once all the changes from next should be available in @primer/css, do the following:

  1. Revert this commit 6d181f9 (renaming the package)
  2. Create a new "release" branch, probably release-15.0.0.
  3. Change the base branch for this PR to release-15.0.0 -> merge it.
  4. Follow the usual RELEASING process.

@vercel
Copy link

vercel bot commented Feb 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-css/3tzazr8d1
✅ Preview: https://primer-css-git-next.primer.vercel.app

@vercel vercel bot temporarily deployed to Preview February 13, 2020 02:24 Inactive
@simurai simurai changed the title Primer CSS Next 🐻 Primer CSS Next Feb 13, 2020
@simurai
Copy link
Contributor Author

simurai commented Feb 14, 2020

Only changing the package name 6d181f9 to publish this branch as @primer/css-next seemed to work fine. 👌

Except that publish @primer/css never finishes. Which is kinda expected? Should we fix this? Maybe in https://github.com/primer/publish?

Screen Shot 2020-02-14 at 12 47 00 PM

On the other hand, might be ok to keep as is since everything else works and we will revert changing the name 6d181f9 again before releasing the changes to @primer/css.

/cc @emplums @BinaryMuse @colebemis

@simurai simurai mentioned this pull request Feb 19, 2020
4 tasks
@vercel vercel bot temporarily deployed to Preview February 19, 2020 00:49 Inactive
@vercel vercel bot temporarily deployed to Preview February 21, 2020 14:06 Inactive
@vercel vercel bot temporarily deployed to Preview May 22, 2020 07:41 Inactive
@vercel vercel bot temporarily deployed to Preview May 26, 2020 05:33 Inactive
@vercel vercel bot temporarily deployed to Preview June 17, 2020 11:05 Inactive
@vercel vercel bot temporarily deployed to Preview July 1, 2020 06:43 Inactive
@vercel vercel bot temporarily deployed to Preview July 2, 2020 08:03 Inactive
@simurai simurai changed the base branch from master to release-15.0.0 July 2, 2020 08:07
@simurai simurai marked this pull request as ready for review July 2, 2020 08:08
@simurai simurai merged commit 703803e into release-15.0.0 Jul 2, 2020
@simurai simurai deleted the next branch July 2, 2020 08:09
@simurai simurai changed the title 🐻 Primer CSS Next 🐻 Component Refresh (charming soft) Aug 3, 2020
@simurai simurai mentioned this pull request Aug 3, 2020
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant