Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure autocomplete resets button styles #1083

Merged
merged 3 commits into from
Jul 2, 2020

Conversation

muan
Copy link
Contributor

@muan muan commented May 12, 2020

This adds some additional styles to .autocomplete-item.

Currently autocomplete-item assumes that the item doesn't come with any UA styles, but in fact they can be blue links or buttons with background colors and borders.

  • .autocomplete-results sets a white background, so it should explicitly set the item text to be something that is dark enough.
  • .autocomplete-item:hover sets a blue background with white text, so it should ensure that the non-hover state is styled with non-inverted colors. So we know the hover state is different to the default state.

Resetting these items with utility classes wouldn't work as they have higher specificity than .autocomplete-item/:hover.

/cc @primer/ds-core

/cc @dinahshi

@vercel
Copy link

vercel bot commented May 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-css/pgd4mayvb
✅ Preview: https://primer-css-git-button-autocomplete-item.primer.now.sh

@vercel vercel bot temporarily deployed to Preview May 12, 2020 22:25 Inactive
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants