-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common marketing utilities to primer/marketing #1254
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-css/BR1qBNY76uRMa6ipyZvK1751wNFq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're just about to release 16.0.0
. Maybe tomorrow. So let's schedule this for 16.1.0
.
Changes look good. Some of these might be handy as non-marketing utilities.. like the z-index and auto margin. I think we wanted to add them for a while already.
🦋 Changeset detectedLatest commit: 5d2f0be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
That sounds great ✨
Happy to move them out from the marketing bundle if that's the case 🙏 |
This PR adds a few common utilities to primer/marketing:
mt-n7
,mb-8
, etc), rather than stopping at 6hover-grow-mktg
animation utility class, as well as an easing variable ($ease-mktg
)m-auto
), for centering elements withposition: absolute
, andmt-auto
for sticking things to the bottom for flex columns within a flex row or a fixed height elementz-1
,z-2
,z-3
,z-n1
,z-n2
)width-auto
andheight-auto
, for resetting width/height of an image, after itswidth
andheight
have been set in HTMLobject-fit-cover
for making an object cover its container https://developer.mozilla.org/en-US/docs/Web/CSS/object-fit/cc @primer/ds-core