Add more Octicon support #1694
Merged
Add more Octicon support #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3984e97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simurai
commented
Oct 22, 2021
Comment on lines
+50
to
+52
| .octicon { | ||
| color: inherit !important; | ||
| } |
There was a problem hiding this comment.
This allows adding colored Octicon icons to a .suggester. The !important is needed when utilities like color-fg-danger are used.
| Before | After |
|---|---|
 |
 |
+ disabled state
simurai
commented
Oct 22, 2021
Comment on lines
+37
to
+40
| .octicon { | ||
| margin-left: $spacer-1; | ||
| color: var(--color-fg-subtle); | ||
| } |
There was a problem hiding this comment.
This adds Octicon support for .radio-group. As well as making options disabled.
simurai
commented
Oct 22, 2021
Comment on lines
+61
to
+68
| &.btn .octicon { | ||
| margin-right: $spacer-1; | ||
| color: var(--color-fg-muted); | ||
| } | ||
|
|
||
| &.btn-primary .octicon { | ||
| color: inherit; | ||
| } |
There was a problem hiding this comment.
This adds support for Octicon icons in .btn in .flash alerts. Without this override the icon picks up the color for icons outside of .btn.
| Before | After |
|---|---|
 |
 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves some dotcom hacks to Primer CSS. See inline comments for more details. Docs are also updated so it's easier to see when regressions happen.