Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backface-visibility to .hover-grow #491

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Conversation

brandonrosage
Copy link
Contributor

Fixes https://github.com/github/education-web/issues/1672

This PR adds one line of CSS to the .hover-grow utility class: backface-visibility: hidden;

That line addresses a visual bug where any images contained within the element would flicker or distort briefly during the animation.

/cc @primer/ds-core

@broccolini
Copy link
Member

@brandonrosage @sophshep Do you need us to ship this quickly? Just checking as we didn't have a release planned next week but happy to do a patch release if needed.

@sophshep
Copy link

I'd categorize this as a "nice-to-have" since it's adding polish vs. fixing something that's broken. I think if you've got a release in the next couple of weeks that would be fine. Thanks for checking though @broccolini!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants