Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix white border on last avatar in AvatarStack (take two) #506

Merged
merged 5 commits into from
Jun 19, 2018

Conversation

shawnbot
Copy link
Contributor

This is a fix for the white border on the last (and first, if only) avatar being visible on other backgrounds, as in our repo commit header:

I've added a story for this to Storybook to test it out:

Before After
image image

@shawnbot shawnbot requested review from califa and a team June 19, 2018 22:02
@shawnbot shawnbot changed the base branch from dev to release-10.6.1 June 19, 2018 22:03
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@shawnbot shawnbot merged commit 91307ee into release-10.6.1 Jun 19, 2018
@shawnbot shawnbot deleted the fix-avatar-stack-border branch June 19, 2018 22:25
This was referenced Jun 19, 2018
@pqt
Copy link
Contributor

pqt commented Jun 20, 2018

@shawnbot

There's some instances of double quotes here, whereas the rest of the file contains only single quotes. I don't think it would break anything but wanted to point it out for consistency sake.

https://github.com/primer/primer/blob/e0ef76f18416c14a29a80e76cd4f16facfe2c46b/modules/primer-avatars/stories.js#L66-L81

This line also contains a hanging space.

https://github.com/primer/primer/blob/e0ef76f18416c14a29a80e76cd4f16facfe2c46b/modules/primer-avatars/stories.js#L67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants