Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to [email protected], rebuild package-lock #579

Merged
merged 5 commits into from
Oct 17, 2018
Merged

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Oct 15, 2018

This is an attempt to get Travis (and local!) bootstraps of the monorepo working again by:

  1. Upgrading to the latest 2.x release of Lerna (v2.11.0)
  2. Renaming the root package.json dependencies field from devDependencies to dependencies
  3. Rebuilding package-lock.json
  4. Running npm audit fix to deal with some security issues

🤞

/cc @primer/ds-core

@shawnbot shawnbot changed the title [WIP] Upgrade to [email protected], rebuild package-lock Upgrade to [email protected], rebuild package-lock Oct 15, 2018
@shawnbot
Copy link
Contributor Author

Okay, I've merged this into #556 and it appears to be working there. In the interest of making it easier to update other branches, I'd like to merge this to master. @jonrohan, you cool with that assuming it looks good otherwise?

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can’t remember if there was a specific reason for putting the dependencies outside of dev, but it seemed to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants