Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix primerize, add "fresh" run-script, etc. #597

Merged
merged 27 commits into from
Nov 9, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
a574add
replace chalk with colorette
shawnbot Nov 7, 2018
919cba8
disable generator-primer-module for now
shawnbot Nov 8, 2018
eda5ed7
rebuild package-lock
shawnbot Nov 8, 2018
647be3f
rebuild package-locks
shawnbot Nov 8, 2018
f9a1946
disable generator-primer-module for now
shawnbot Nov 8, 2018
38aee6e
replace chalk with colorette
shawnbot Nov 7, 2018
ef03786
update react + react-dom
shawnbot Nov 8, 2018
147aaa9
chalk -> colorette
shawnbot Nov 8, 2018
2157206
nix per package package-lock.json
shawnbot Nov 8, 2018
4deb812
bring primer-module-build back into the fold
shawnbot Nov 8, 2018
9d237e6
move primer-support to devDependencies in generator
shawnbot Nov 8, 2018
a60e72c
tell lerna not to create package-lock.json
shawnbot Nov 8, 2018
b1117b4
rework "clean" run-script; add "fresh"
shawnbot Nov 8, 2018
3c5217f
regenerate package-lock.json
shawnbot Nov 8, 2018
769f10b
update DEVELOP.md with new install guidance
shawnbot Nov 8, 2018
9c6e29f
upgrade to es6, add prettier config
shawnbot Nov 8, 2018
3af1845
create classes.json at prepare time
shawnbot Nov 8, 2018
ab21342
add subdir package-lock.json to .gitignore
shawnbot Nov 8, 2018
36ed5a8
disable selector-no-utility in primer-utilities
shawnbot Nov 8, 2018
1dc859c
lint before testing
shawnbot Nov 8, 2018
8a6d6bf
lint
shawnbot Nov 8, 2018
532329d
always prepare in prepublishOnly?
shawnbot Nov 8, 2018
bb8b015
add classes.json to git?
shawnbot Nov 8, 2018
6c39c22
don't run prepare in prepublishOnly
shawnbot Nov 9, 2018
5c4d5b0
Merge branch 'release-10.9.0' into fix-primerize
shawnbot Nov 9, 2018
61a9ab9
kill peer dependencies again
shawnbot Nov 9, 2018
7dbe4c4
exit silently on prefresh failure
shawnbot Nov 9, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
*.lerna_backup
*.log
*/*/package-lock.json
.DS_Store
.changelog
.sass-cache
node_modules
*.log
build
_site
*.lerna_backup
.changelog
build
node_modules
10 changes: 8 additions & 2 deletions DEVELOP.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,18 @@ Run `npm install` to install the npm dependencies and automatically run link all
If you run into trouble installing, it's always best to ensure that you're starting from a clean slate by running the following from the repository root directory:

```sh
npx lerna clean --yes
npm run fresh
```

If _that_ gives you problems, then you can try manually deleting everything and starting over:

```
rm -rf node_modules
rm -f package-lock.json */*/package-lock.json
npm install
```

**You may need to do this whenever switching between branches with different dependencies, submodules, or versions of Node and/or npm.** The Primer core team generally uses the latest major version of Node (10 as of this writing), but we run our CI tests on Node 8 and npm 6. You can check which versions you're running with:
**You may need to do this whenever switching between branches with different dependencies, submodules, or versions of Node and/or npm.** The Primer core team generally uses the latest major version of Node (10 as of this writing), but our CI tests run Node 8 and npm 6. You can check which versions you're running with:

```sh
npm --version
Expand Down
8 changes: 5 additions & 3 deletions lerna.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
{
"lerna": "2.4.0",
"version": "independent",
"packages": [
"modules/*",
"tools/*"
"tools/*",
"!tools/generator-primer-module"
],
"npmClientArgs": ["--no-package-lock"],
"changelog": {
"repo": "primer/primer",
"labels": {
Expand All @@ -15,6 +18,5 @@
"Tag: Internal": ":house: Internal"
},
"cacheDir": ".changelog"
},
"version": "independent"
}
}
11 changes: 0 additions & 11 deletions modules/primer-alerts/package-lock.json

This file was deleted.

11 changes: 0 additions & 11 deletions modules/primer-avatars/package-lock.json

This file was deleted.

11 changes: 0 additions & 11 deletions modules/primer-base/package-lock.json

This file was deleted.

11 changes: 0 additions & 11 deletions modules/primer-blankslate/package-lock.json

This file was deleted.

11 changes: 0 additions & 11 deletions modules/primer-box/package-lock.json

This file was deleted.

11 changes: 0 additions & 11 deletions modules/primer-branch-name/package-lock.json

This file was deleted.

11 changes: 0 additions & 11 deletions modules/primer-breadcrumb/package-lock.json

This file was deleted.

11 changes: 0 additions & 11 deletions modules/primer-buttons/package-lock.json

This file was deleted.

155 changes: 0 additions & 155 deletions modules/primer-core/package-lock.json

This file was deleted.

11 changes: 0 additions & 11 deletions modules/primer-forms/package-lock.json

This file was deleted.

11 changes: 0 additions & 11 deletions modules/primer-labels/package-lock.json

This file was deleted.

11 changes: 0 additions & 11 deletions modules/primer-layout/package-lock.json

This file was deleted.

11 changes: 0 additions & 11 deletions modules/primer-markdown/package-lock.json

This file was deleted.

11 changes: 0 additions & 11 deletions modules/primer-marketing-buttons/package-lock.json

This file was deleted.

3 changes: 0 additions & 3 deletions modules/primer-marketing-buttons/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@
"dependencies": {
"primer-support": "4.6.1"
},
"peerDependencies": {
"primer-buttons": "2.6.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be moved into dependencies if it's removed from peerDeps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to kill the peer dependencies because they weren't adding any value. In both of these cases, the peer dependencies weren't "runtime" dependencies in Sass land.

},
"keywords": [
"css",
"github",
Expand Down
5 changes: 0 additions & 5 deletions modules/primer-marketing-support/package-lock.json

This file was deleted.

Loading