Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move select menu list into the modal div #903

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Move select menu list into the modal div #903

merged 1 commit into from
Sep 25, 2019

Conversation

mxie
Copy link
Contributor

@mxie mxie commented Sep 19, 2019

Otherwise the list won't actually show up.

This should make it consistent with all the other examples where the header and the list are at the same level of nesting.

/cc @primer/ds-core

@mxie
Move select menu list into the modal div
a0948b0 
Otherwise the list won't actually show up.
@vercel
Copy link

vercel bot commented Sep 19, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-fork-mxie-patch-1.primer.now.sh

simurai
simurai approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxie Thanks for catching that. Yes, the list should be inside the modal. 👍 👍 👍

This was referenced Sep 21, 2019
Merged
Merged
@shawnbot shawnbot changed the base branch from master to release-13.0.2 September 25, 2019 22:34
@shawnbot shawnbot merged commit d848952 into primer:release-13.0.2 Sep 25, 2019
@shawnbot
Copy link
Contributor

Thanks for this, @mxie!!

@mxie
Copy link
Contributor Author

mxie commented Sep 26, 2019

@shawnbot Sure thing! Thanks for the quick turnaround. :)

@mxie mxie deleted the patch-1 branch September 26, 2019 13:01
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simurai simurai simurai approved these changes

@shawnbot shawnbot Awaiting requested review from shawnbot

Assignees
No one assigned
Labels
patch release Tag: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxie @shawnbot @simurai