Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [role=tab][aria-selected=true] to .UnderlineNav-item.selected #945

Merged
merged 3 commits into from
Oct 25, 2019
Merged

Add [role=tab][aria-selected=true] to .UnderlineNav-item.selected #945

merged 3 commits into from
Oct 25, 2019

Conversation

shawnbot
Copy link
Contributor

Fixes #934.

@shawnbot shawnbot requested a review from simurai October 14, 2019 23:27
@vercel
Copy link

vercel bot commented Oct 14, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/aqjcdpach
🌍 Preview: https://primer-css-git-underline-nav-tab-container.primer.now.sh

@shawnbot shawnbot mentioned this pull request Oct 14, 2019
Merged
simurai
simurai reviewed Oct 15, 2019
View reviewed changes
src/navigation/underline-nav.scss Show resolved Hide resolved
src/navigation/underline-nav.scss Outdated Show resolved Hide resolved
@shawnbot shawnbot changed the base branch from master to release-14.0.0 October 22, 2019 18:45
@shawnbot shawnbot mentioned this pull request Oct 22, 2019
Merged
15 tasks
@shawnbot shawnbot changed the base branch from release-14.0.0 to release-13.2.0 October 22, 2019 23:57
simurai
simurai approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a non-blocking comment about removing :not([aria-current=false]). Otherwise 👍

src/navigation/underline-nav.scss Outdated Show resolved Hide resolved
@simurai
Copy link
Contributor

simurai commented Oct 25, 2019

Ok, this looks ready too.. 🚢

@simurai simurai merged commit 036ed32 into release-13.2.0 Oct 25, 2019
@simurai simurai deleted the underline-nav-tab-container branch October 25, 2019 04:35
@github-actions github-actions bot mentioned this pull request Dec 17, 2022
Open
This was referenced Jan 8, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simurai simurai simurai approved these changes

Assignees
No one assigned
Labels
Tag: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawnbot @simurai