Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save shield-slash-24.svg #924

Merged
merged 4 commits into from
Mar 1, 2023
Merged

Save shield-slash-24.svg #924

merged 4 commits into from
Mar 1, 2023

Conversation

CameronFoxly
Copy link
Contributor

Adding the 24px version of shield-slash, requested in this issue.

@CameronFoxly CameronFoxly requested a review from a team as a code owner February 28, 2023 19:44
@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2023

🦋 Changeset detected

Latest commit: 78a877d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@gavinmn gavinmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think this one is suffering from the "sliding top half" more than the 16px version, but we haven't found a good solution for addressing this issue quite yet.

@colebemis colebemis merged commit 6b494df into main Mar 1, 2023
@colebemis colebemis deleted the shield-slash-24 branch March 1, 2023 19:23
@primer-css primer-css mentioned this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants