Update nav links #162
Update nav links #162
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-style-git-nav-update.primer.now.sh |
|
Gatsby redirects are weird. I think that both the to and from URLs are expanded to "paths", because redirecting from |
| icon: require.resolve('./src/icons/favicon-192.png') | ||
| } | ||
| } | ||
| 'gatsby-plugin-meta-redirect' |
There was a problem hiding this comment.
According to the docs, this needs to go last.
| import Team from '../components/Team' | ||
| import Layout from '../components/Layout' | ||
|
|
||
| <div id="team/"> |
There was a problem hiding this comment.
This is a workaround for Gatsby's appending of / to redirect destination paths. Even though we specify /about/#team as the toPath, it treats the whole thing as a "path" and appends it at the end of the string, producing /about/#team/ — which "works" if we provide an anchor with id="team/" (including the slash). 🤷♀
This replaces the nav from Blueprints with a custom one that we'll eventually replace again with the one that lives in Doctocat, and implements the nav updates listed in #152
/cc @colebemis