Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make static assets available on path alias #238

Merged
merged 59 commits into from
Sep 11, 2018
Merged

Make static assets available on path alias #238

merged 59 commits into from
Sep 11, 2018

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Sep 5, 2018

This does a couple of things:

  • Adds a custom HTTP server that solely sets the Next app's assetPrefix to the deployed host in the NOW_URL env var if it's being served on another domain. This is what makes it work at primer.style/components/
  • Adds PNGs for the favicon and apple touch icon to static/assets/, and updates their paths in the document component.
  • Introduces the @zeit/next-sass plugin to generate our custom CSS build and put it in the right place.
  • Includes all the stuff in Streamline npm publish and Now deploy files #242

If development process was changed

Nothing has changed development-wise. You still run npm run dev locally, and Now runs npm build then npm start, which also starts the server. The Next dev option is set to true if NODE_ENV !== 'production', so there's no need to set NODE_ENV=development.

Merge checklist

  • Changed base branch to release branch
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@shawnbot shawnbot requested a review from a team September 5, 2018 22:08
@vercel
Copy link

vercel bot commented Sep 5, 2018

This pull request is automatically deployed with Now.

To access deployments, click Details below or on the icon next to each push.

@shawnbot shawnbot changed the base branch from release-2.0.2-beta to fresh-mdx September 5, 2018 22:27
@vercel

This comment has been minimized.

@vercel

This comment has been minimized.

@vercel

This comment has been minimized.

@vercel

This comment has been minimized.

@vercel

This comment has been minimized.

@vercel

This comment has been minimized.

@shawnbot shawnbot changed the base branch from release-2.0.2-beta to master September 10, 2018 18:08
@shawnbot
Copy link
Contributor Author

@emplums let's review this and merge to master rather than holding it up for a release.

Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Feel free to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants