Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies to fix weird errors #253

Merged
merged 14 commits into from
Sep 14, 2018
Merged

Update dependencies to fix weird errors #253

merged 14 commits into from
Sep 14, 2018

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Sep 13, 2018 •
edited
Loading

We're both pretty stumped by the cause of this, but only the spacing system props stopped functioning at some point, and only when deployed to Now. Here's what @emplums and I did to fix it:

  1. Remove static rendering of styled-components elements
  2. Downgrade system-components to 2.x
  3. Upgrade emotion and styled-system to latest version
  4. Upgrade enzyme to avoid forwardRef: Enzyme Internal Error: unknown node with tag 14 enzymejs/enzyme#1604

@vercel
Copy link

vercel bot commented Sep 13, 2018

This pull request is automatically deployed with Now.

To access deployments, click Details below or on the icon next to each push.

@shawnbot
Copy link
Contributor Author

So yeah, now all our tests are failing. FML.

@shawnbot shawnbot changed the base branch from master to q3-scrambled-eggs September 13, 2018 23:24
@emplums emplums mentioned this pull request Sep 13, 2018
Merged
9 tasks
emplums
emplums approved these changes Sep 14, 2018
View reviewed changes
Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's merge it!

@shawnbot shawnbot merged commit ba17ff5 into q3-scrambled-eggs Sep 14, 2018
@shawnbot shawnbot deleted the fix-the-things branch September 14, 2018 16:33
@shawnbot shawnbot mentioned this pull request Sep 14, 2018
Merged
@shawnbot shawnbot changed the title Fix the things Update dependencies to fix weird errors Sep 14, 2018
@shawnbot shawnbot mentioned this pull request Sep 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emplums emplums emplums approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawnbot @emplums