-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(PageHeader): add role prop and aria-label in top-level element #4956
fix(PageHeader): add role prop and aria-label in top-level element #4956
Conversation
🦋 Changeset detectedLatest commit: 863c1e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
…6-prcpageheader-best-practice-container-lacks-a-role
…r-lacks-a-role' of github.com:primer/react into francinelucca/3466-prcpageheader-best-practice-container-lacks-a-role
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/341930 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🫡
Closes https://github.com/github/primer/issues/3466
Changelog
New
role
prop inPageHeader
PageHeader
tests to assert added functionalityChanged
role="banner"
andaria-label
to applicable instances ofPageHeader
in Storybook and testsaria-label
attribute inPageHeader
's "root" element mapped to the suppliedaria-label
PageHeader
'saria-label
docs description to reference "landmark" instead of inaccurate "main landmark"aria-label
prop inPageHeader
Playground storyRemoved
N/A
Rollout strategy
Testing & Reviewing
Integration Test: https://github.com/github/github/pull/341930
Box
element and thearia-label
that maps to thetitle
proptitle
prop in playground and notice thearia-label
change in the DOM as wellBox
element and thearia-label
Merge checklist