feat: add experimental IssueLabel component #4960
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding color algo for hex colors * fix tests * update snap name * test(vrt): update snapshots --------- Co-authored-by: Katie Langerman <[email protected]> Co-authored-by: langermank <[email protected]>
🦋 Changeset detectedLatest commit: 5d9a13a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
requested review from
emilybrick,
camertron,
lukasoppermann,
broccolinisoup and
langermank
lukasoppermann
approved these changes
Sep 16, 2024
broccolinisoup
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
The code overall looks good to me! And it is great to have accessible colours on the labels 🎉 Thanks so much for your work on this 🙏🏻
Just a few points/questions:
- Is
IssueLabelgoing to be a replacement for the currentLabelcomponent? - When I tried setting hex colours on the playground story, sometimes it throws an error with
Failed to parse color: "#0f0f0"(as I shared below on the screenshot)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling work from #4535 to add support for an experimental
IssueLabelcomponentChangelog
New
Changed
Removed
Rollout strategy