Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Select panel loading states" #5136

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Revert "Select panel loading states" #5136

merged 1 commit into from
Oct 16, 2024

Conversation

joshblack
Copy link
Member

Reverts #4929

@joshblack joshblack requested review from a team as code owners October 16, 2024 18:45
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: 1b5a934

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 16, 2024
@joshblack joshblack requested review from camertron and broccolinisoup and removed request for keithamus and emilybrick October 16, 2024 18:47
@joshblack joshblack added the skip changeset This change does not need a changelog label Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.88 KB (-0.82% 🔽)
packages/react/dist/browser.umd.js 97.31 KB (-0.64% 🔽)

@joshblack joshblack added this pull request to the merge queue Oct 16, 2024
joshblack added a commit that referenced this pull request Oct 16, 2024
@joshblack
Revert "Select panel loading states (#4929)" (#5136)
f93eb9b 
This reverts commit 843ea47.
Merged via the queue into main with commit f93eb9b Oct 16, 2024
50 checks passed
@joshblack joshblack deleted the revert-4929-select_panel_loading_states branch October 16, 2024 19:00
broccolinisoup added a commit that referenced this pull request Oct 17, 2024
@broccolinisoup
Revert "Revert "Select panel loading states (#4929)" (#5136)"
245a841 
This reverts commit f93eb9b.
@broccolinisoup broccolinisoup mentioned this pull request Oct 17, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camertron camertron camertron approved these changes

@broccolinisoup broccolinisoup Awaiting requested review from broccolinisoup

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @camertron