Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust DeprecatedArguments cop to handle boolean values #1182

Merged
merged 5 commits into from
Jun 1, 2022

Conversation

camertron
Copy link
Contributor

The DeprecatedArguments cop currently only supports string and symbol values. This PR adds support for true and false.

@camertron camertron requested review from langermank, a team and manuelpuyol June 1, 2022 18:06
@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2022

🦋 Changeset detected

Latest commit: 3f4fc9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron temporarily deployed to github-pages June 1, 2022 18:09 Inactive
@camertron camertron temporarily deployed to github-pages June 1, 2022 18:41 Inactive
@camertron camertron merged commit 33fc790 into main Jun 1, 2022
@camertron camertron deleted the handle_boolean_deprecated_arguments branch June 1, 2022 18:54
@primer-css primer-css mentioned this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants