-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete design updates #1189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jon Rohan <[email protected]>
…er/view_components into autocomplete-design-updates
… autocomplete-design-updates
…er/view_components into autocomplete-design-updates
…er/view_components into autocomplete-design-updates
Co-authored-by: Cameron Dutro <[email protected]>
Co-authored-by: Cameron Dutro <[email protected]>
Co-authored-by: Cameron Dutro <[email protected]>
Co-authored-by: Cameron Dutro <[email protected]>
Co-authored-by: Jon Rohan <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These markup and CSS changes bring the Autocomplete component in closer alignment with PRC and design.
Overlay
andActionList
for the picker stylesFormControl
styles to align with Rails forms and PRC.In order to safely roll out these changes, this PR moves the current
Autocomplete
and correspondingItem
back toalpha
status, also deprecating them. When this release rolls out to GitHub, all implementations ofAutocomplete::Beta
will be moved back toAutocomplete::Alpha
. Feature teams will have the ability to safely update to Beta on their own timeline.Upgrading from Alpha to Beta
Most of these param changes are auto-fixable when upgrading to
beta
. RefactoringAutoComplete::Beta::Item
is more nuanced.For Hubbers only: please use this draft PR as a reference for upgrading to Beta.
AutoComplete
param changes and additionsis_label_visible
visually_hide_label
false
with_icon
<% c.leading_visual_icon(icon: :search) %>
is_clearable
show_clear_button
false
placeholder
disabled
size:
:small
,:medium
,:large
:medium
inset
false
monospace
false
full_width
false
AutoComplete::Item
param changes and additionsleading_visual_icon
<% c.leading_visual_icon(icon: :search) %>
leading_visual_avatar
<% c.leading_visual_avatar(src: "") %>
trailing_visual_icon
<% c.trailing_visual_icon(icon: :search) %>
description
<% c.description { "Description" } %>
description_variant
:inline
,:block
:block
AutoComplete::Item
aria-selected
view:CleanShot.2022-07-27.at.17.57.16.mp4
Closes: https://github.com/github/primer/issues/1133