Set aria-hidden="true" when type is label
#1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f8a1110 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
khiga8
force-pushed
the
kh-add-aria-hidden-when-labelledby
branch
from
b88e314
to
934beeb
Compare
|
To do on Monday: share codespaces URL with @jscholes |
camertron
approved these changes
Jul 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a change so that when the tooltip type is
labelestablishing anaria-labelledbyrelationship, the tooltip element will havearia-hidden="true". The reason for this change is to avoid screen reader users needing to hear duplicated content that they already hear when they navigate on the control itself.This change has been made based on an internal Slack conversation and recommendation from @jscholes.