-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate Primer::BoxComponent to Primer::Box #1266
Conversation
🦋 Changeset detectedLatest commit: 735fccb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I just want to make sure we space it out in releases between other renames like it so we don't have too many migrations at once in github/github.
Blocking so we don't accidentally add it to a release when we're not ready
split from #676
this PR renames
Primer::BoxComponent
toPrimer::Box
, adjusts all references to it, and adds a deprecated BoxComponent for backward compatibility. the component remains instable
statusadditionally, a previous PR had a last minute change to use
.to_sentence
on an array of valid states. this method isn't available, so it's been changed back to a hard coded list for now.files to note
there's a lot of files changed in this pr, but most of them are only reference changes. here are the important files to review:
screenshots
storybook page for box:
doc site for box: