Always set :absolute
position on Primer::Alpha::Tooltip
#1281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on
SegmentedController
and noticed a small size jump with the components. It turns out because there's a moment before the Javascript is loaded in that the Tooltip is hidden, but is taking up dom space. It isn't noticeable in our previews because we're only rendering one of the items that have a tooltip, but I disabled JS for the screenshot below and put a second button in line.I think we should have a hardcoded
position: absolute;
css that will keep the element out of the flow even when JS fails to load. I opted for adding the system argument, but I'm open to other ways.