Re-add array checkboxes #1390
Merged
Re-add array checkboxes #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c1e6580 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
We need to interpolate the value into template names specifically for array-style checkboxes without affecting how existing non-array checkboxes look for their caption templates. Co-authored-by: Cameron Dutro <[email protected]>
neall
force-pushed
the
re-add-array-checkboxes
branch
from
920698b
to
c1e6580
Compare
camertron
approved these changes
Sep 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially array-style checkboxes were conflicting with existing checkbox components using caption templates. This will make it so only the array-style checkboxes will require a value in the template name.
(Because all of the checkboxes in an "array" have the same name, templates need to differ based on the value in that case.)