Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Primer::IconButton in favor of Primer::Beta::IconButton #1397

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Deprecate Primer::IconButton in favor of Primer::Beta::IconButton #1397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03db528
deprecated Primer::IconButton in favor of Primer::Beta::IconButton
mxriverlynn Sep 21, 2022
7b3f2b3
added changeset
mxriverlynn Sep 21, 2022
8af5d58
docs: build docs
actions-user Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/olive-eggs-dream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/view-components': patch
---

deprecated Primer::IconButton in favor of Primer::Beta::IconButton"
2 changes: 1 addition & 1 deletion app/components/primer/icon_button.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ module Primer
# Either `aria-label` or `aria-description` will be used for the `Tooltip` text, depending on which one is present.
# [Learn more about best functional image practices (WAI Images)](https://www.w3.org/WAI/tutorials/images/functional)
class IconButton < Primer::Component
status :beta
status :deprecated

DEFAULT_SCHEME = :default
SCHEME_MAPPINGS = {
Expand Down
2 changes: 1 addition & 1 deletion docs/src/@primer/gatsby-theme-doctocat/nav.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
- title: HiddenTextExpander
url: "/components/alpha/hiddentextexpander"
- title: IconButton
url: "/components/iconbutton"
url: "/components/beta/iconbutton"
- title: Image
url: "/components/image"
- title: ImageCrop
Expand Down
1 change: 1 addition & 0 deletions lib/primer/deprecations.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ module Deprecations
"Primer::FlexItemComponent" => nil,
"Primer::HeadingComponent" => "Primer::Beta::Heading",
"Primer::HiddenTextExpander" => "Primer::Alpha::HiddenTextExpander",
"Primer::IconButton" => "Primer::Beta::IconButton",
"Primer::Tooltip" => "Primer::Alpha::Tooltip"
}.freeze

Expand Down
2 changes: 1 addition & 1 deletion static/statuses.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"Primer::HeadingComponent": "deprecated",
"Primer::HellipButton": "alpha",
"Primer::HiddenTextExpander": "deprecated",
"Primer::IconButton": "beta",
"Primer::IconButton": "deprecated",
"Primer::Image": "alpha",
"Primer::ImageCrop": "alpha",
"Primer::LabelComponent": "beta",
Expand Down