Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lookbook previews for Beta Button and IconButton #1400

Merged
merged 19 commits into from
Sep 23, 2022
Merged

Conversation

langermank
Copy link
Contributor

Previews!

@langermank langermank requested a review from a team as a code owner September 22, 2022 19:22
@langermank langermank requested review from a team and jonrohan September 22, 2022 19:22
@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2022

🦋 Changeset detected

Latest commit: 44667f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank temporarily deployed to review-pr-1400 September 22, 2022 19:22 Inactive
@langermank langermank temporarily deployed to github-pages September 22, 2022 19:25 Inactive
@jonrohan
Copy link
Member

jonrohan commented Sep 22, 2022

Nice! While you're here, what do you think about deleting the preview for the old IconButton, I think it's test/previews/primer/icon_button_preview.rb. Also replace the old buttons in the tooltip previews http://primer-view-components-preview-1400.eastus.azurecontainer.io/view-components/lookbook/inspect/primer/alpha/tooltip/default

@langermank langermank temporarily deployed to review-pr-1400 September 22, 2022 19:59 Inactive
@langermank langermank temporarily deployed to github-pages September 22, 2022 20:03 Inactive
@langermank langermank temporarily deployed to github-pages September 22, 2022 21:33 Inactive
@langermank langermank temporarily deployed to review-pr-1400 September 22, 2022 21:44 Inactive
@langermank langermank temporarily deployed to github-pages September 22, 2022 21:49 Inactive
@langermank langermank temporarily deployed to review-pr-1400 September 22, 2022 22:13 Inactive
@langermank langermank temporarily deployed to github-pages September 22, 2022 22:18 Inactive
@langermank langermank temporarily deployed to github-pages September 23, 2022 17:43 Inactive
@langermank langermank merged commit ae48b9f into main Sep 23, 2022
@langermank langermank deleted the button-previews-2 branch September 23, 2022 22:15
@primer-css primer-css mentioned this pull request Sep 23, 2022
keithamus pushed a commit that referenced this pull request Sep 27, 2022
* add preview

* add previews for button + css fixes

* docs: build docs

* add icon button previews

* delete old icon button preview

* update tooltip previews with new button

* lint

* lint is confused

* lint..

* no comment

* space

* Create friendly-walls-rest.md

* have your link button

* docs: build docs

* rename

* remove comment

Co-authored-by: Actions Auto Build <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants