Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon button hide tooltip #1491

Merged
merged 4 commits into from
Oct 13, 2022
Merged

Icon button hide tooltip #1491

merged 4 commits into from
Oct 13, 2022

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Oct 13, 2022

Description

Adds the ability to hide the tooltip on IconButtons. This was requested by the Actions team, members of which are seeing tooltips cover other UI elements, making them hard to see and interact with. From an a11y perspective, icon buttons can also have their tooltips hidden if the meaning of the icon is widely understood.

Integration

Does this change require any updates to code in production?

No.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2022

🦋 Changeset detected

Latest commit: 14aec89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Oct 13, 2022
@camertron camertron temporarily deployed to github-pages October 13, 2022 18:32 Inactive
@camertron camertron marked this pull request as ready for review October 13, 2022 18:33
@camertron camertron requested review from a team and jonrohan October 13, 2022 18:33
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@camertron camertron merged commit f43bd08 into main Oct 13, 2022
@camertron camertron deleted the icon_button_hide_tooltip branch October 13, 2022 20:26
@primer-css primer-css mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants