Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add relative-time component #1650

Merged
merged 4 commits into from
Dec 6, 2022
Merged

add relative-time component #1650

merged 4 commits into from
Dec 6, 2022

Conversation

keithamus
Copy link
Member

Description

This adds a new RelativeTime component, which replaces the LocalTime and TimeAgo components.

It also changes the LocalTime and TimeAgo components to use the relative-time web component, as they currently use local-time and time-ago components, which themselves are deprecated as they are just configurations over the relative-time component.

Integration

Does this change require any updates to code in production?
Currently no, but we want to deprecate LocalTime and TimeAgo and switch them over to RelativeTime.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2022

🦋 Changeset detected

Latest commit: 0fa10e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2022

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@keithamus keithamus temporarily deployed to review-pr-1650 November 29, 2022 18:53 Inactive
@keithamus keithamus temporarily deployed to review-pr-1650 November 30, 2022 09:14 Inactive
@github-actions github-actions bot added the css Pull requests that update CSS code label Dec 2, 2022
@github-actions github-actions bot removed the css Pull requests that update CSS code label Dec 2, 2022
@keithamus keithamus temporarily deployed to review-pr-1650 December 2, 2022 12:37 Inactive
@keithamus keithamus temporarily deployed to review-pr-1650 December 2, 2022 15:17 Inactive
@ollie-iterators ollie-iterators mentioned this pull request Dec 2, 2022
54 tasks
@keithamus keithamus temporarily deployed to review-pr-1650 December 5, 2022 16:12 Inactive
@keithamus keithamus temporarily deployed to review-pr-1650 December 6, 2022 11:54 Inactive
@keithamus keithamus marked this pull request as ready for review December 6, 2022 11:54
@keithamus keithamus requested review from a team and camertron December 6, 2022 11:54
@keithamus keithamus temporarily deployed to github-pages December 6, 2022 11:58 Inactive
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great

@keithamus keithamus merged commit 2941ba2 into main Dec 6, 2022
@keithamus keithamus deleted the add-relative-time branch December 6, 2022 17:43
@primer-css primer-css mentioned this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants