Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip rendering form controls and entire forms #1668

Merged
merged 3 commits into from
Dec 5, 2022

Conversation

camertron
Copy link
Contributor

Description

View components can skip rendering themselves by returning false from the render? method. This PR adds the same functionality to form components (for internal use) and entire form objects.

Integration

Does this change require any updates to code in production?

No

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2022

🦋 Changeset detected

Latest commit: 6cff7e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron temporarily deployed to review-pr-1668 December 2, 2022 22:54 Inactive
@camertron camertron temporarily deployed to github-pages December 2, 2022 22:58 Inactive
@camertron camertron marked this pull request as ready for review December 2, 2022 23:27
@camertron camertron requested review from a team and keithamus December 2, 2022 23:27
@camertron camertron temporarily deployed to github-pages December 2, 2022 23:27 Inactive
@camertron camertron requested review from jonrohan and removed request for keithamus December 5, 2022 18:22
@camertron camertron merged commit 84cd95e into main Dec 5, 2022
@camertron camertron deleted the skip_render_form_components branch December 5, 2022 19:13
@primer-css primer-css mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants