Move Layout styles to PVC
#1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0059d13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
It's still needed for Primer::LayoutComponent
simurai
commented
Dec 6, 2022
| @@ -799,383 +799,6 @@ | |||
| } | |||
| } | |||
|
|
|||
| .Layout { | |||
There was a problem hiding this comment.
@mxriverlynn FYI: I removed all the Layout styles here and also in app/lib/primer/css/layout.css.json since they are now part of Primer::Alpha::Layout.
4 tasks
keithamus
approved these changes
Dec 6, 2022
jonrohan
approved these changes
Dec 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of #1342 and adds the
Layoutstyles from PCSS. There should be no visual changes.What should reviewers focus on
Layoutstyles in app/lib/primer/css/ are removed so they don't show up in search.Primer::LayoutComponent. But decided against it since dotcom usesPrimer::LayoutComponentonly in 6 files. So maybe ok to just wait until allPrimer::LayoutComponentuses are migrated toPrimer::Alpha::Layout.px. Mostly to avoid regressions and fixes to the custom media queries, see Slack.Integration
Yes, the following line can be removed on dotcom:
- @import '@primer/css/layout/layout.scss';Merge checklist
Added/updated documentation