-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support ViewComponent v3.0.0.rc2 #1832
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes the only changes necessary to support ViewComponent v3.0.0.rc2. I intentionally tread carefully here so as to allow PVC to work with older versions of ViewComponent.
🦋 Changeset detectedLatest commit: 148cefd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joelhawksley
had a problem deploying
to
review-pr-1832
February 17, 2023 20:18
— with
GitHub Actions
Error
joelhawksley
temporarily deployed
to
github-pages
February 17, 2023 20:23
— with
GitHub Actions
Inactive
joelhawksley
force-pushed
the
vc-3.0.0.rc2
branch
from
February 17, 2023 20:31
a247092
to
3acb2dc
Compare
joelhawksley
temporarily deployed
to
review-pr-1832
February 17, 2023 20:31
— with
GitHub Actions
Inactive
joelhawksley
temporarily deployed
to
github-pages
February 17, 2023 20:36
— with
GitHub Actions
Inactive
joelhawksley
temporarily deployed
to
review-pr-1832
February 17, 2023 20:51
— with
GitHub Actions
Inactive
joelhawksley
temporarily deployed
to
github-pages
February 17, 2023 20:55
— with
GitHub Actions
Inactive
joelhawksley
temporarily deployed
to
review-pr-1832
February 21, 2023 15:14
— with
GitHub Actions
Inactive
joelhawksley
temporarily deployed
to
github-pages
February 21, 2023 15:19
— with
GitHub Actions
Inactive
joelhawksley
temporarily deployed
to
review-pr-1832
February 21, 2023 15:47
— with
GitHub Actions
Inactive
joelhawksley
temporarily deployed
to
github-pages
February 21, 2023 15:50
— with
GitHub Actions
Inactive
camertron
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the only changes necessary to support ViewComponent v3.0.0.rc2. I intentionally tread carefully here so as to allow PVC to work with older versions of ViewComponent.