Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ViewComponent v3.0.0.rc2 #1832

Merged
merged 8 commits into from
Feb 21, 2023
Merged

support ViewComponent v3.0.0.rc2 #1832

merged 8 commits into from
Feb 21, 2023

Conversation

joelhawksley
Copy link
Contributor

This PR makes the only changes necessary to support ViewComponent v3.0.0.rc2. I intentionally tread carefully here so as to allow PVC to work with older versions of ViewComponent.

This PR makes the only changes necessary to support ViewComponent
v3.0.0.rc2. I intentionally tread carefully here so as to allow
PVC to work with older versions of ViewComponent.
@joelhawksley joelhawksley requested review from a team and camertron February 17, 2023 20:18
@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2023

🦋 Changeset detected

Latest commit: 148cefd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Feb 17, 2023
@joelhawksley joelhawksley temporarily deployed to github-pages February 17, 2023 20:23 — with GitHub Actions Inactive
@joelhawksley joelhawksley temporarily deployed to review-pr-1832 February 17, 2023 20:31 — with GitHub Actions Inactive
@joelhawksley joelhawksley temporarily deployed to github-pages February 17, 2023 20:36 — with GitHub Actions Inactive
@joelhawksley joelhawksley temporarily deployed to review-pr-1832 February 17, 2023 20:51 — with GitHub Actions Inactive
@joelhawksley joelhawksley temporarily deployed to github-pages February 17, 2023 20:55 — with GitHub Actions Inactive
@joelhawksley joelhawksley temporarily deployed to review-pr-1832 February 21, 2023 15:14 — with GitHub Actions Inactive
@joelhawksley joelhawksley temporarily deployed to github-pages February 21, 2023 15:19 — with GitHub Actions Inactive
@joelhawksley joelhawksley temporarily deployed to review-pr-1832 February 21, 2023 15:47 — with GitHub Actions Inactive
@joelhawksley joelhawksley temporarily deployed to github-pages February 21, 2023 15:50 — with GitHub Actions Inactive
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@camertron camertron merged commit 557ec8b into main Feb 21, 2023
@camertron camertron deleted the vc-3.0.0.rc2 branch February 21, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants