Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon button to overlay show #1865

Merged
merged 6 commits into from
Mar 3, 2023
Merged

Conversation

keithamus
Copy link
Member

Description

This adds some aria attributes to the show_button on Overlay.

It also allows for IconButtons to be rendered if an Icon is supplied.

Refs #1830

Integration

Does this change require any updates to code in production?

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@keithamus keithamus requested review from a team and camertron March 3, 2023 12:14
@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2023

🦋 Changeset detected

Latest commit: d485bd2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@keithamus keithamus temporarily deployed to preview March 3, 2023 12:18 — with GitHub Actions Inactive
@keithamus keithamus temporarily deployed to github-pages March 3, 2023 12:23 — with GitHub Actions Inactive
@keithamus keithamus temporarily deployed to preview March 3, 2023 16:20 — with GitHub Actions Inactive
@keithamus keithamus temporarily deployed to github-pages March 3, 2023 16:25 — with GitHub Actions Inactive
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@keithamus keithamus merged commit df8dcce into main Mar 3, 2023
@keithamus keithamus deleted the add-icon-button-to-overlay-show branch March 3, 2023 17:16
@primer-css primer-css mentioned this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants