Remove ability to show trailing action buttons in ActionList and NavList on hover #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 079c55c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
force-pushed
the
remove_action_list_show_on_hover
branch
from
94fa990
to
079c55c
Compare
jonrohan
approved these changes
Mar 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
show_on_hover:option from thetrailing_actionslot forNavLists andActionLists. It has been determined this behavior is fundamentally not accessible and is potentially also confusing for people who don't use assistive technologies. See the discussion on https://github.com/github/primer/issues/1120 for more information.Integration
Yes. There is currently one usage of the show on hover behavior in dotcom. Our plan is to preserve the behavior in this one case by introducing a custom item component.
Merge checklist