fix popover close button #1994
Merged
fix popover close button #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1d7c4a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🤔 this is not working for me http://primer-view-components-preview-1994.eastus.azurecontainer.io/view-components/lookbook/inspect/primer/alpha/overlay/playground Screen.Recording.2023-05-10.at.8.59.02.AM.mov |
jonrohan
reviewed
May 10, 2023
jonrohan
approved these changes
May 10, 2023
jonrohan
approved these changes
May 10, 2023
Merged
camertron
pushed a commit
that referenced
this pull request
May 19, 2023
Co-authored-by: Jon Rohan <[email protected]> Co-authored-by: Jon Rohan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors the close button for popovers, moving from the old
popoverhidetargetto the standardpopovertarget/popovertargetaction=hide.Closes #1989
Integration
Merge checklist