Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update color vars for Button with counter #2008

Merged
merged 6 commits into from
May 31, 2023
Merged

Update color vars for Button with counter #2008

merged 6 commits into from
May 31, 2023

Conversation

langermank
Copy link
Contributor

@langermank langermank commented May 12, 2023 •
edited
Loading

Description

Improves contrast for primary and danger buttons with counters

Part of https://github.com/github/primer/issues/2135

before after
button before button after

Integration

Does this change require any updates to code in production?

May need to bump PCSS in dotcom too?

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 5ffd1a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank temporarily deployed to preview May 12, 2023 16:17 — with GitHub Actions Inactive
@github-actions github-actions bot added the css Pull requests that update CSS code label May 12, 2023
@langermank langermank temporarily deployed to github-pages May 12, 2023 16:22 — with GitHub Actions Inactive
@langermank langermank temporarily deployed to github-pages May 31, 2023 18:34 — with GitHub Actions Inactive
@langermank langermank marked this pull request as ready for review May 31, 2023 18:43
@langermank langermank requested a review from a team as a code owner May 31, 2023 18:43
@langermank langermank requested review from a team, tobiasahlin and camertron May 31, 2023 18:43
@github-actions
Copy link
Contributor

Uh oh! @langermank, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@langermank langermank temporarily deployed to github-pages May 31, 2023 18:45 — with GitHub Actions Inactive
@langermank langermank temporarily deployed to preview May 31, 2023 18:47 — with GitHub Actions Inactive
@langermank langermank temporarily deployed to github-pages May 31, 2023 18:51 — with GitHub Actions Inactive
@langermank langermank merged commit 5319044 into main May 31, 2023
@langermank langermank deleted the update-button-counter-colors branch May 31, 2023 22:48
@primer-css primer-css mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@tobiasahlin tobiasahlin Awaiting requested review from tobiasahlin tobiasahlin is a code owner automatically assigned from primer/css-reviewers

@camertron camertron Awaiting requested review from camertron

Assignees
No one assigned
Labels
css Pull requests that update CSS code patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langermank @jonrohan