Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select doc example #2009

Merged
merged 5 commits into from
May 12, 2023
Merged

Fix select doc example #2009

merged 5 commits into from
May 12, 2023

Conversation

camertron
Copy link
Contributor

Description

The Select component was renamed a little while ago which also affected the corresponding previews. Unfortunately the name of the preview was not updated in the doc generator code. I fixed the preview name and made sure the generator code raises an error now if the preview doesn't exist.

Integration

Does this change require any updates to code in production?

No

Merge checklist

- [ ] Added/updated tests
- [ ] Added/updated documentation
- [ ] Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2023

🦋 Changeset detected

Latest commit: 57f51e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron merged commit 65745bf into main May 12, 2023
@camertron camertron deleted the fix_select_doc_example branch May 12, 2023 18:35
@primer-css primer-css mentioned this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants