Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing fallback plugin imports for multi files #2058

Merged
merged 14 commits into from
Jun 8, 2023
Merged

Fixing fallback plugin imports for multi files #2058

merged 14 commits into from
Jun 8, 2023

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Jun 1, 2023 •
edited by langermank
Loading

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

  • Feed multiple @primitive fallback files into the fallback PostCSS plugin. This plugin adds fallback values at build time to the .css files.
  • Remove manual fallback values from .pcss files

Integration

No changes in prod

List the issues that this change affects.

Relates to [Primitives v8] Generate fallback values for PostCSS excluding color#2254

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 8756fe4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan temporarily deployed to preview June 1, 2023 21:21 — with GitHub Actions Inactive
@jonrohan jonrohan temporarily deployed to github-pages June 1, 2023 21:27 — with GitHub Actions Inactive
@github-actions github-actions bot added the css Pull requests that update CSS code label Jun 1, 2023
@langermank langermank temporarily deployed to preview June 1, 2023 22:00 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023 •
edited
Loading

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@langermank langermank temporarily deployed to preview June 1, 2023 22:18 — with GitHub Actions Inactive
@langermank langermank marked this pull request as ready for review June 1, 2023 22:37
@langermank langermank requested a review from a team as a code owner June 1, 2023 22:37
@langermank langermank requested review from a team and langermank June 1, 2023 22:37
@langermank langermank temporarily deployed to preview June 1, 2023 22:37 — with GitHub Actions Inactive
@langermank langermank requested a review from keithamus June 1, 2023 22:37
camertron
camertron approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know what's going on here, but I trust you.

@langermank langermank temporarily deployed to preview June 1, 2023 23:01 — with GitHub Actions Inactive
@langermank
Copy link
Contributor

Looks good other than the Gatsby docs issue 😅

@langermank langermank temporarily deployed to preview June 6, 2023 18:29 — with GitHub Actions Inactive
langermank
langermank approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@jonrohan jonrohan merged commit 3e50e06 into main Jun 8, 2023
@jonrohan jonrohan deleted the postcss_fallback_script branch June 8, 2023 16:24
@primer-css primer-css mentioned this pull request Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@camertron camertron camertron approved these changes

@keithamus keithamus Awaiting requested review from keithamus

Assignees

@jonrohan jonrohan

@langermank langermank

Labels
css Pull requests that update CSS code patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonrohan @langermank @camertron