Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flex-start instead of start #2073

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Use flex-start instead of start #2073

merged 1 commit into from
Jun 12, 2023

Conversation

camertron
Copy link
Contributor

What are you trying to accomplish?

This PR changes align-items: start to align-items: flex-start as (apparently) start has spotty browser support.

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

We're seeing a Primer webpack build error in dotcom with the following message:

42:3    ⚠  start value has mixed support, consider using flex-start instead [autoprefixer]

I just followed the instructions from the error message. Everything seems to work as expected 👍

Merge checklist

- [ ] Added/updated tests
- [ ] Added/updated documentation
- [ ] Added/updated previews (Lookbook)

  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2023

🦋 Changeset detected

Latest commit: 40646fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the problem 🤘🏻

@camertron camertron merged commit c4ada3b into main Jun 12, 2023
@camertron camertron deleted the autoprefixer_flex_start branch June 12, 2023 18:40
@primer-css primer-css mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css Pull requests that update CSS code patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants