Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix guide URLs (in lib/primer/deprecations.yml) #2203

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Conversation

orhantoy
Copy link
Contributor

@orhantoy orhantoy commented Aug 11, 2023

The previous URLs are returning 404 at the moment.

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Fix guide URLs which I think are used for instance with ERB lint, which is where I originally saw the issue.

Screenshots

Screenshot of logs from Action saying: 'Primer:: ButtonComponent' has been deprecated. Please update your code to use 'Primer:: Beta:: Button'. See https://primer.style/view-components/guides/primer_button_component for more information.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Searched the docs and found replacement URLs.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

The previous URLs are returning 404 at the moment.
@orhantoy orhantoy requested review from a team and camertron August 11, 2023 09:28
@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2023

🦋 Changeset detected

Latest commit: b201147

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Uh oh! @orhantoy, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonrohan jonrohan enabled auto-merge (squash) August 11, 2023 16:34
@jonrohan jonrohan merged commit 3f50402 into main Aug 11, 2023
26 of 27 checks passed
@jonrohan jonrohan deleted the orhantoy/fix-guide-urls branch August 11, 2023 16:36
@primer primer bot mentioned this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants